Appruve.process - Code Metrics - bytesfield/sabi-customer - Measure and Improve Code Quality continuously with Scrutinizer

Appruve.process A
last analyzed 2021-06-09 21:25 UTC

↳ Parent: Appruve

Complexity

Conditions

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
dl	0
loc	6
rs	10
c	0
b	0
f	0

const httpProcessor = require('../HttpProcessor');
const services = require('../config/services');
const constants = require('../config/constants');

class Appruve
{
    constructor() {
        this.client = services.appruve.client;
        this.apiKey = services.appruve.api_key;
        this.baseUrl = services.appruve.api_url;

    }

    /**
    * Process axios calls
    * 
    * @param {string} method The call method get|post|put|delete|patch
    * @param {string} url The url to call
    * @param {object|formData} payload The payload data to send with the call
    */
    process(method, url, payload) {
         //HttpProcessor class to handle axios calls
        let processor = new httpProcessor(this.baseUrl, this.apiKey, this.client);

        
        return processor.process(method, url, payload)
    }

    /**
    * Handles the ID request
    *
    * @param {object} IdFilter
    * @return {object}
    */
    async handle(IdFilter)
    {
        if (!IdFilter.isSuccessful()) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
            
            const idType = IdFilter.getIDType().toUpperCase();
            const country=IdFilter.getCountry().toLowerCase();
            const type = this.getType(idType);
            const url = '/v1/verifications/' + country + '/' + type;
            
            const idNumber =  IdFilter.getIDNumber();
            const firstName =  IdFilter.getFirstName();
            const lastName =  IdFilter.getLastName();
            const middleName =  IdFilter.getMiddleName();
            const dateOfBirth =  IdFilter.getDOB();
            const phone =  IdFilter.getPhoneNumber();
            const expiryDate =  IdFilter.getExpiry();
            const gender =  IdFilter.getGender();
            const address =  IdFilter.getAddress();
            const pin =  IdFilter.getPin();
            const tin =  IdFilter.getTin();
            const full_name =  IdFilter.getFullName();
            const company = IdFilter.getCompany();
            const registration_number =  IdFilter.getRegistrationNumber();

            const body = {
                'id' : idNumber,
                'first_name' : firstName,
                'last_name' : lastName,
                'middle_name' : middleName,
                'date_of_birth' : dateOfBirth,
                'phone_number' : phone,
                'expiry_date' : expiryDate,
                'gender' : gender,
                'address' : address,
                'pin' : pin,
                'tin' : tin,
                'full_name' : full_name,
                'company_name' : company,
                'registration_number' : registration_number
            };
            
            try {
                const response = await this.process('POST', url, body);

                IdFilter.confirmSuccess();
                
                IdFilter.setHandler(this.client);

                IdFilter.setData({
                    'handler' : IdFilter.getHandler(),
                    'country' : IdFilter.getCountry().toUpperCase(),
                    'message' : idType + ' Verified' + ' Successfully',
                    'data' : response
                });

                return IdFilter.getData();
                
            } catch (error) {
                IdFilter.setError({'error' : error});
                
                return IdFilter.getError();
            }
        }

    }

    /**
     * Transform the ID
     *
     * @param {string} type
     * @return {string}
     */
    getType(type)
    {
        if (type === constants.idValues.TYPE_NATIONAL_ID  || type === constants.idValues.TYPE_NIN ) {
            return 'national_id';
        }
        if (type === constants.idValues.TYPE_DRIVERS_LICENSE) {
            return 'driver_license';
        }
        if (type === constants.idValues.TYPE_VOTER_CARD) {
            return 'voter';
        }
        if (type === constants.idValues.TYPE_BVN) {
            return 'bvn';
        }
        if (type === constants.idValues.TELCO_SUBSCRIBER) {
            return 'telco_subscriber';
        }
        return type.toLowerCase();
    }
}

module.exports = Appruve;

1			const httpProcessor = require('../HttpProcessor');
2			const services = require('../config/services');
3			const constants = require('../config/constants');
4
5			class Appruve
6			{
7			constructor() {
8			this.client = services.appruve.client;
9			this.apiKey = services.appruve.api_key;
10			this.baseUrl = services.appruve.api_url;
11
12			}
13
14			/**
15			* Process axios calls
16			*
17			* @param {string} method The call method get\|post\|put\|delete\|patch
18			* @param {string} url The url to call
19			* @param {object\|formData} payload The payload data to send with the call
20			*/
21			process(method, url, payload) {
22			//HttpProcessor class to handle axios calls
23			let processor = new httpProcessor(this.baseUrl, this.apiKey, this.client);
			0 ignored issues – show Coding Style Best Practice introduced 2021-06-09 20:56 UTC by Report Bug Copy Issue Report By convention, constructors like `httpProcessor` should be capitalized. Loading history...
24
25			return processor.process(method, url, payload)
26			}
27
28			/**
29			* Handles the ID request
30			*
31			* @param {object} IdFilter
32			* @return {object}
33			*/
34			async handle(IdFilter)
35			{
36			if (!IdFilter.isSuccessful()) {
			0 ignored issues – show Complexity Best Practice introduced 2021-06-09 20:56 UTC by Report Bug Copy Issue Report There is no return statement if `!IdFilter.isSuccessful()` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
37
38			const idType = IdFilter.getIDType().toUpperCase();
39			const country=IdFilter.getCountry().toLowerCase();
40			const type = this.getType(idType);
41			const url = '/v1/verifications/' + country + '/' + type;
42
43			const idNumber = IdFilter.getIDNumber();
44			const firstName = IdFilter.getFirstName();
45			const lastName = IdFilter.getLastName();
46			const middleName = IdFilter.getMiddleName();
47			const dateOfBirth = IdFilter.getDOB();
48			const phone = IdFilter.getPhoneNumber();
49			const expiryDate = IdFilter.getExpiry();
50			const gender = IdFilter.getGender();
51			const address = IdFilter.getAddress();
52			const pin = IdFilter.getPin();
53			const tin = IdFilter.getTin();
54			const full_name = IdFilter.getFullName();
55			const company = IdFilter.getCompany();
56			const registration_number = IdFilter.getRegistrationNumber();
57
58			const body = {
59			'id' : idNumber,
60			'first_name' : firstName,
61			'last_name' : lastName,
62			'middle_name' : middleName,
63			'date_of_birth' : dateOfBirth,
64			'phone_number' : phone,
65			'expiry_date' : expiryDate,
66			'gender' : gender,
67			'address' : address,
68			'pin' : pin,
69			'tin' : tin,
70			'full_name' : full_name,
71			'company_name' : company,
72			'registration_number' : registration_number
73			};
74
75			try {
76			const response = await this.process('POST', url, body);
77
78			IdFilter.confirmSuccess();
79
80			IdFilter.setHandler(this.client);
81
82			IdFilter.setData({
83			'handler' : IdFilter.getHandler(),
84			'country' : IdFilter.getCountry().toUpperCase(),
85			'message' : idType + ' Verified' + ' Successfully',
86			'data' : response
87			});
88
89			return IdFilter.getData();
90
91			} catch (error) {
92			IdFilter.setError({'error' : error});
93
94			return IdFilter.getError();
95			}
96			}
97
98			}
99
100			/**
101			* Transform the ID
102			*
103			* @param {string} type
104			* @return {string}
105			*/
106			getType(type)
107			{
108			if (type === constants.idValues.TYPE_NATIONAL_ID \|\| type === constants.idValues.TYPE_NIN ) {
109			return 'national_id';
110			}
111			if (type === constants.idValues.TYPE_DRIVERS_LICENSE) {
112			return 'driver_license';
113			}
114			if (type === constants.idValues.TYPE_VOTER_CARD) {
115			return 'voter';
116			}
117			if (type === constants.idValues.TYPE_BVN) {
118			return 'bvn';
119			}
120			if (type === constants.idValues.TELCO_SUBSCRIBER) {
121			return 'telco_subscriber';
122			}
123			return type.toLowerCase();
124			}
125			}
126
127			module.exports = Appruve;

bytesfield / sabi-customer

Appruve.process A last analyzed 2021-06-09 21:25 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Appruve.process A
last analyzed 2021-06-09 21:25 UTC